Page 1 of 1

Fix demo player bug

Posted: Fri Nov 13, 2015 10:18 pm
by milk
Hi. I started to make videos from demos and I noticed an ugly bug in demo player. It draws movement of weapons in the hands incorrectly when the gun passes through zero angle.


What I actually do:
bug1.png
bug1.png (51.04 KiB) Viewed 3821 times
This is how demo player draw it:
bug2.png
bug2.png (55.91 KiB) Viewed 3821 times
Zero angle:
bug3.png
bug3.png (48.39 KiB) Viewed 3821 times
For greater clarity, you can also download this demo and play it with different speed to see this bug in action:
demo player bug.demo
(42.2 KiB) Downloaded 126 times
You may have noticed this effect on some videos. That looks ugly sometimes -.-
For example: https://youtu.be/kT8k66dNG8Y?t=78 (01:18 - 01:22)

I spent some hours with debugger and I think I fixed it. (need to check https://github.com/ddnet/ddnet/pull/369)

By the way is anyone else noticed this bug? Because it seems it's there since a long time.

Re: Fix demo player bug

Posted: Fri Nov 13, 2015 10:30 pm
by kamillentee
I always wondered why I often took the long way to aim in demo player.

Re: Fix demo player bug

Posted: Fri Nov 13, 2015 10:59 pm
by deen
It's not just demo player, but also when you watch other players I think. I noticed it for a long time.

Re: Fix demo player bug

Posted: Fri Nov 13, 2015 11:27 pm
by milk
deen wrote:It's not just demo player, but also when you watch other players I think.
I'll check that too. Thanks, deen.

Re: Fix demo player bug

Posted: Sat Nov 14, 2015 1:09 am
by HMH
It is an old known problem but nobody fixed it till now: https://github.com/teeworlds/teeworlds/issues/1260

Re: Fix demo player bug

Posted: Sat Nov 14, 2015 3:53 am
by milk
HMH wrote:It is an old known problem but nobody fixed it till now: https://github.com/teeworlds/teeworlds/issues/1260
Thanks, added pull request for this issue. Hope it's good enough solution.


It seems this bug appears only in demo player. Spectate on the server is ok.

Re: Fix demo player bug

Posted: Sun Nov 15, 2015 7:57 pm
by Im 'corneum
i always had this bug, but i thought that it looks somehow more "prolike" ,that spin.

Re: Fix demo player bug

Posted: Mon Nov 16, 2015 1:24 am
by BamBam
plz dont fix it, it looks really cool!

Re: Fix demo player bug

Posted: Mon Nov 16, 2015 2:24 pm
by HMH
Too late, already fixed ^^