Page 1 of 2

DDNet client, filter servers

Posted: Fri Jul 29, 2016 9:44 am
by Lumpy ◐ω◑
Hi, in DDNet client we can filter servers with "search" and "exclude" fields. Can you rework a bit this fields behavier? So if there are several words, the filter will search not the whole phrase, but words. For example if I want to exclude DDNet novice and solo servers, I'll type in field "novice solo" and filter will exclude servers, that contains word "novice" or word "solo".
Thanks.

Re: DDNet client, filter servers

Posted: Fri Jul 29, 2016 9:50 am
by deen
good idea, but it should still support whole phrases, maybe split them up by pressing enter and show each phrase in a bubble. So for your use case you would write novice<ENTER>solo, if someone is searching for "foo bar" they could just keep writing it as they do now. Everyone who likes programming is welcome to write this. We accept PRs on DDNet's github. If you need help, post here or on DDNet irc.

Re: DDNet client, filter servers

Posted: Fri Jul 29, 2016 10:59 am
by Chairn
So basically, you want regexp in those fields?

Re: DDNet client, filter servers

Posted: Fri Jul 29, 2016 11:55 am
by Lumpy ◐ω◑
deen, splitting by enter is good idea or we can use comma :) I've managed to write in code filtering for words (as I described) and its working, but I don't know C++ at all and did this with google help :D so I think my code can be not so good.
Chairn, not really regexp, just wanted to exclude from server list novice and brutal maps :D

Re: DDNet client, filter servers

Posted: Fri Jul 29, 2016 4:43 pm
by Ryozuki
deen wrote:good idea, but it should still support whole phrases, maybe split them up by pressing enter and show each phrase in a bubble. So for your use case you would write novice<ENTER>solo, if someone is searching for "foo bar" they could just keep writing it as they do now. Everyone who likes programming is welcome to write this. We accept PRs on DDNet's github. If you need help, post here or on DDNet irc.
Pressing enter makes you connect to a server, doesn't it? Maybe it's better coma separated

Re: DDNet client, filter servers

Posted: Fri Jul 29, 2016 9:23 pm
by Pathos
How about Google format? You can use quotes for exact phrases, OR for or, etc.

Re: DDNet client, filter servers

Posted: Sat Jul 30, 2016 9:16 pm
by fokkonaut
can any1 tell me wherefor the exclude search is actually?

Re: DDNet client, filter servers

Posted: Sun Jul 31, 2016 1:50 am
by BannZay
As for me comma is perfect. It should be simple and undertandable for most users

Re: DDNet client, filter servers

Posted: Sun Jul 31, 2016 12:22 pm
by deen
I implemented comma, but then I noticed that string highlighting (the found text turning blue) becomes quite challenging with it. Not sure if we want that, actually.

Re: DDNet client, filter servers

Posted: Tue Aug 02, 2016 8:20 am
by Lumpy ◐ω◑
Can we disable highlighting? Or implement comma only in exclude string, if highlighting is impossible?