DDNet clients crashes when saving a map

[FakeDeath]

I have been working on a map. A few minutes ago, I wanted to save my map when suddenly the DDNet client crashed. Not crashing crashing, but closing within a second right after I clicked on the save button. I was shocked and immediately went to ...\AppData\Roaming\Teeworlds\maps. The map name was still there, but the content of it: 0 kB.

I worked days on that map and now it's gone. Luckily my local DDNet server was online, so after seeing that the content of my map was gone, I went opened teeworlds and went to the server. Such a relieve that the map with the content was still online, so I took screenshots of every part of the map. Now I have to remake the whole map with the screenshots I got. That's going to take long...

Why writing this little story? Because I don't want this to happen again. So to the developer and maintainer of the DDNet client: could you find any kind of bug in the program that can cause this event?

By the way, this happened with the 4.3.1 version.

p.s. From now on I am going to use multiple saves. E.g. [name]V1, [name]V2, [name]V3, ....

[Ama]

you should give details on what you did in the last sitting

if you added images or something you think coused it

[Index]

The exact same problem happend to me once. But that was like two months ago, so whatever causes this bug was there in previous versions as well. Unfortuantely I don't remember exactly what I was doing before saving the map :(

[FakeDeath]

Between the last succesful save and the 'crash save', I did not:
- add or remove images.
- add or remove groups.
- add or remove any new layer/ tile/ quad/ ....
- close the DDNet client to do something else. (close = alt + tab).

Between the last succesful save and the 'crash save', I did:

- place and remove tiles/ blocks with the current layers/ tiles I had.
- play on the server to test parts while with the editor open. After testing, I continued with mapping, saved and tested it again until I wanted to save again and the 'crash save' happened.
- use a dummy on the server (to test the parts).

[deen]

FakeDeath: look in the directory AppData\Roaming\Teeworlds\downloadedmaps
It should be there.
Edit: I just went through the saving code and the only thing I can imagine is your computer running out of memory, which would crash the client during a save. I didn't find anything else unfortunately. If you can find a way to reproduce this bug, I can fix it easily.
Edit2: Another idea: Do you have autosave on?

[imp]

This once happened to me too, but in a bit different way. I pressed save button (like 1 year ago) and the game crashed. I thought, dude, why crash now..dickhead. Then I wanted to reopen the map and the game freezed...every time. I don't know if the "buggy" .map file had 0 KBs though...

Luckily you seem to have tested your map already, so the losses shouldn't be to enormous, if there are even any. As I am more the theoretically mapper I map likely the whole map first before I set any entities or test any part. So NO downloaded backup file. You guessed it, make backups from time to time and you are fine

[FakeDeath]

Pfew... I found the map in AppData\Roaming\Teeworlds\downloadedmaps. Thanks, deen.

Tnx for all the help guys...

[deen]

FakeDeath: Can you comment if it was one of these causes:

Edit: I just went through the saving code and the only thing I can imagine is your computer running out of memory, which would crash the client during a save. I didn't find anything else unfortunately. If you can find a way to reproduce this bug, I can fix it easily.
Edit2: Another idea: Do you have autosave on?

[FakeDeath]

I tried, but couldn't reproduce the bug.

Out of memory:
All the opened programs at that time: Kaspersky (firewall + virusscan, standard background, was not running a check or any thing), steam, skype, windows media player and teeworlds itself. All opened programs right now: the same + google chrome browser. I've the statics of right now, which are: CPU=5% max and RAM=70% max. (max means when there is a spike) This means, because at that time google chrome wasn't active, that it should be less CPU and RAM in use at that time than right now.

Autosave:
I couldn't find this setting any where in the DDNet client, but I don't see any autosave-maps in the map-map, so I don't think it's on.

Size of map:
The size of the map is 2000x2000 to make sure I've enough space. At the end, I'll smaller this, of course. So when I had to save, it took around 5 seconds. At the beginning of that saving progress, the DDNet client crashed.