Fix demo player bug

[milk]

Hi. I started to make videos from demos and I noticed an ugly bug in demo player. It draws movement of weapons in the hands incorrectly when the gun passes through zero angle.


What I actually do:

bug1.png (51.04 KiB) Viewed 3741 times

This is how demo player draw it:

bug2.png (55.91 KiB) Viewed 3741 times

Zero angle:

bug3.png (48.39 KiB) Viewed 3741 times

For greater clarity, you can also download this demo and play it with different speed to see this bug in action:

demo player bug.demo

(42.2 KiB) Downloaded 118 times

You may have noticed this effect on some videos. That looks ugly sometimes -.-
For example: https://youtu.be/kT8k66dNG8Y?t=78 (01:18 - 01:22)

I spent some hours with debugger and I think I fixed it. (need to check https://github.com/ddnet/ddnet/pull/369)

By the way is anyone else noticed this bug? Because it seems it's there since a long time.

[kamillentee]

I always wondered why I often took the long way to aim in demo player.

[deen]

It's not just demo player, but also when you watch other players I think. I noticed it for a long time.

[milk]

It's not just demo player, but also when you watch other players I think.

I'll check that too. Thanks, deen.

[HMH]

It is an old known problem but nobody fixed it till now: https://github.com/teeworlds/teeworlds/issues/1260

[milk]

It is an old known problem but nobody fixed it till now: https://github.com/teeworlds/teeworlds/issues/1260

Thanks, added pull request for this issue. Hope it's good enough solution.


It seems this bug appears only in demo player. Spectate on the server is ok.

[Im 'corneum]

i always had this bug, but i thought that it looks somehow more "prolike" ,that spin.

[BamBam]

plz dont fix it, it looks really cool!

[HMH]

Too late, already fixed ^^